linux-kernel - Re: [PATCH] Fix vmi time header bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Mar 2007 22:31:36 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Zachary Amsden <zach@...are.com>
Cc:	ak@...e.de, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH] Fix vmi time header bug

> On Mon, 12 Mar 2007 14:58:08 -0800 Zachary Amsden <zach@...are.com> wrote:
> Some gcc put this function in .init.text because the header didn't 
> match.  For 2.6.21-rc.
> 
> Zach
> 
> 
> [vmi-devinit-header-fix.patch  text/plain (606B)]
> 
> 
> Index: linux-2.6.21/include/asm-i386/vmi_time.h
> ===================================================================
> --- linux-2.6.21.orig/include/asm-i386/vmi_time.h	2007-03-06 18:56:03.000000000 -0800
> +++ linux-2.6.21/include/asm-i386/vmi_time.h	2007-03-12 13:55:16.000000000 -0800
> @@ -54,7 +54,7 @@ extern unsigned long vmi_cpu_khz(void);
>  
>  #ifdef CONFIG_X86_LOCAL_APIC
>  extern void __init vmi_timer_setup_boot_alarm(void);
> -extern void __init vmi_timer_setup_secondary_alarm(void);
> +extern void __devinit vmi_timer_setup_secondary_alarm(void);
>  extern void apic_vmi_timer_interrupt(void);
>  #endif

Really truly?   I think we have a _lot_ of declarations which omit the section
qualifier altogether.  How come they don't all break too?

(ARM (at least) in fact does require the section tagging on the declaration as
well as the definition, but we've thus far only fixed that in a couple of places
which were causing breakage).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/