linux-kernel - Re: [PATCH 00/18] Make common x86 arch area for i386 and x86_64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070314181508.GB12994@elte.hu>
Date:	Wed, 14 Mar 2007 19:15:08 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Glauber de Oliveira Costa <glommer@...il.com>
Subject: Re: [PATCH 00/18] Make common x86 arch area for i386 and x86_64 - Take 2

* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> > symbolic links perhaps? In that case i'd also introduce a common 
> > naming scheme: x86_early_printk.c - to make sure we know it right 
> > away that those files are bi-arch.
> 
> Hey, I know! This is a radical idea, but what if we put the name at 
> the head of the file, and called it
> 
> 	arch/x86/kernel/early_printk.c
> 
> instead? Then we could teach each of i386 and x86-64 to include it 
> from that area, and we could put other shared files under the same 
> directory hierarchy so that it would be easy to see which ones are 
> shared?

that is nice too, but it has some disadvantages as well in practice. For 
example i often want to see 'everything' that belongs to an arch in just 
one subdirectory. That way one can grep it for example, instead of 
having to grep two separate places. Symlinks would be fine for that, but 
an explicit split not really i think - unless we can get some really 
significant chunk of code into that hierarchy, so that it makes 
functional /sense/ to look at it in isolation.

with the prefix suggestion we can keep these 'shared' files merged in a 
single, main functional tree (x86_64), but still have them marked in the 
VFS as being shared. But ... either way is fine to me - no strong 
feelings, really.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/