linux-kernel - Re: [PATCH 0/2] wistron

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000703141158t4d02b8b7pc4ab967722dac@mail.gmail.com>
Date:	Wed, 14 Mar 2007 14:58:49 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Vojtech Pavlik" <vojtech@...e.cz>
Cc:	"Eric Piel" <Eric.Piel@...mplin-utc.net>, mitr@...ny.cz,
	otauber@....de, linux-kernel@...r.kernel.org,
	linux-input <linux-input@...ey.karlin.mff.cuni.cz>
Subject: Re: [PATCH 0/2] wistron_btns: More keymaps

On 3/14/07, Vojtech Pavlik <vojtech@...e.cz> wrote:
> On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote:
> > Hi Eric,
> >
> > On 3/13/07, Eric Piel <Eric.Piel@...mplin-utc.net> wrote:
> > >Hello,
> > >
> > >As a sequel to my patch "Wistron button support for TravelMate 610" of
> > >last week, here is a bigger addition of keymaps for the wistron_btns.
> > >
> > >Patch 1 adds all the database of acerhk which fits this driver (about 25
> > >more laptops).
> > >Patch 2 adds a generic map that should fit most users but has the
> > >disadvantage of not being automatic.
> > >
> > >Dmitry, I've tried to make them against your tree. Still, if they don't
> > >apply cleanly, just tell me and I'll try harder!
> > >
> >
> > I have couple of comments/requests:
> >
> > 1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the
> > lid, they correspond to Accpication Control Open and Close keys from
> > USB HID HUT spec:
> >
> >     http://www.usb.org/developers/devclass_docs/Hut1_12.pdf
> >
> > SW_LID shoudl be used to signal lid state instead.
> >
> > 2. I also have a concern about using KEY_SCREEN to signal toggling
> > display on and off. I am CCing Vojtech - he must know what the
> > original intent of this key code was. BTW, when user presses
> > corresponding button - does the display actually goes off? Maybe we
> > need another switch.
>
> Sorry, Dmitry, I probably should have documented it back then, I don't
> have the slightest idea anymore.
>

That's what I was afraid of ;) Well, maybe we should just use it to
indicate display switch and add a comment to that effect to input.h...

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/