linux-kernel - [PATCH] fix cyclades.h for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070314215746.GA7781@mars.oe1kib.ampr.org>
Date:	Wed, 14 Mar 2007 22:57:47 +0100
From:	Klaus Kudielka <klaus.kudielka@....net>
To:	linux-kernel@...r.kernel.org
Cc:	ivan@...lades.com
Subject: [PATCH] fix cyclades.h for x86_64 (and probably others)

Hello,

at least on x86_64 the present cyclades.h is broken due to the wrong size
of uclong. This affects, of course, both the kernel and the user-level
utilities. The symptom is that cyzload refuses to load the firmware.
I also managed to freeze the machine when unloading the module.

The patch below fixes this in an architecture-independent way.
I have tested it with 2.6.19 and the driver works fine again with a
Cyclades-Z on an Athlon 64 X2.

Please CC to me personally, as I am not subscribed to the list.
Thanks, Klaus

--- include/linux/cyclades.h.ORIG       2007-02-23 12:48:19.000000000 +0000
+++ include/linux/cyclades.h    2007-03-14 21:24:35.000000000 +0000
@@ -149,14 +149,12 @@
  *     architectures and compilers.
  */
 
-#if defined(__alpha__)
-typedef unsigned long  ucdouble;       /* 64 bits, unsigned */
-typedef unsigned int   uclong;         /* 32 bits, unsigned */
-#else
-typedef unsigned long  uclong;         /* 32 bits, unsigned */
-#endif
-typedef unsigned short ucshort;        /* 16 bits, unsigned */
-typedef unsigned char  ucchar;         /* 8 bits, unsigned */
+#include <asm/types.h>
+
+typedef __u64  ucdouble;       /* 64 bits, unsigned */
+typedef __u32  uclong;         /* 32 bits, unsigned */
+typedef __u16  ucshort;        /* 16 bits, unsigned */
+typedef __u8   ucchar;         /* 8 bits, unsigned */
 
 /*
  *     Memory Window Sizes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/