linux-kernel - Re: [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070315135241.GG8321@wotan.suse.de>
Date:	Thu, 15 Mar 2007 14:52:41 +0100
From:	Nick Piggin <npiggin@...e.de>
To:	Ankita Garg <ankita@...ibm.com>
Cc:	Linux Memory Management <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable

On Thu, Mar 15, 2007 at 07:19:21PM +0530, Ankita Garg wrote:
> 
> Looking at oom_kill.c, found that the intention to not kill the selected
> process if any of its children/siblings has OOM_DISABLE set, is not being met.
> 
> 
> Signed-off-by: Ankita Garg <ankita@...ibm.com>
Acked-by: Nick Piggin <npiggin@...e.de>

> 
> Index: ankita/linux-2.6.20.1/mm/oom_kill.c
> ===================================================================
> --- ankita.orig/linux-2.6.20.1/mm/oom_kill.c	2007-02-20 12:04:32.000000000 +0530
> +++ ankita/linux-2.6.20.1/mm/oom_kill.c	2007-03-15 12:44:50.000000000 +0530
> @@ -320,7 +320,7 @@
>  	 * Don't kill the process if any threads are set to OOM_DISABLE
>  	 */
>  	do_each_thread(g, q) {
> -		if (q->mm == mm && p->oomkilladj == OOM_DISABLE)
> +		if (q->mm == mm && q->oomkilladj == OOM_DISABLE)
>  			return 1;
>  	} while_each_thread(g, q);
>  
> 
> Regards,
> -- 
> Ankita Garg (ankita@...ibm.com)
> Linux Technology Center
> IBM India Systems & Technology Labs, 
> Bangalore, India   
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/