linux-kernel - Re: [PATCH] BLK_DEV_IDE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <45F9588C.7020108@ru.mvista.com>
Date:	Thu, 15 Mar 2007 17:30:36 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Akira Iguchi <akira2.iguchi@...hiba.co.jp>
Cc:	bzolnier@...il.com, torvalds@...ux-foundation.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	Al Viro <viro@....linux.org.uk>
Subject: Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix

Hello.

Akira Iguchi wrote:

> It's bool and it depends on BLK_DEV_IDE
>  => should depend on BLK_DEV_IDE=y

    Hm, why I'm seeing module_init() in the driver? :-)

> And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on 
> BLK_DEV_IDEDMA_PCI.

    IMHO, that driver shouldn't be in drivers/ide/ppc/ then...  Why it got 
there (the same question about PowerMac driver)?

> diff -Nrpu -X linux-2.6.21-rc3/Documentation/dontdiff linux-2.6.21-rc3/drivers/ide/Kconfig linux-2.6.21-rc3.mod/drivers/ide/Kconfig
> --- linux-2.6.21-rc3/drivers/ide/Kconfig	2007-03-07 13:41:20.000000000 +0900
> +++ linux-2.6.21-rc3.mod/drivers/ide/Kconfig	2007-03-15 23:49:33.000000000 +0900
> @@ -769,6 +769,14 @@ config BLK_DEV_TC86C001
>  	help
>  	This driver adds support for Toshiba TC86C001 GOKU-S chip.
>  
> +config BLK_DEV_IDE_CELLEB
> +	bool "Toshiba's Cell Reference Set IDE support"
> +	depends on PPC_CELLEB && BLK_DEV_IDE=y
> +	help
> +	  This driver provides support for the built-in IDE controller on
> +	  Toshiba Cell Reference Board.
> +	  If unsure, say Y.
> +
>  endif
>  
>  config BLK_DEV_IDE_PMAC
> @@ -800,14 +808,6 @@ config BLK_DEV_IDEDMA_PMAC
>  	  to transfer data to and from memory.  Saying Y is safe and improves
>  	  performance.
>  
> -config BLK_DEV_IDE_CELLEB
> -	bool "Toshiba's Cell Reference Set IDE support"
> -	depends on PPC_CELLEB
> -	help
> -	  This driver provides support for the built-in IDE controller on
> -	  Toshiba Cell Reference Board.
> -	  If unsure, say Y.
> -
>  config BLK_DEV_IDE_SWARM
>  	tristate "IDE for Sibyte evaluation boards"
>  	depends on SIBYTE_SB1xxx_SOC

MBR, Sergei

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/