linux-kernel - Re: [PATCH] mm/filemap.c: unconditionally call mark_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070315110735.287c8a23.akpm@linux-foundation.org>
Date:	Thu, 15 Mar 2007 11:07:35 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ashif Harji <asharji@...uwaterloo.ca>
Cc:	dingxn@....ohio-state.edu, shaggy@...ux.vnet.ibm.com,
	andi@...x01.fht-esslingen.de, linux-mm@...ck.org, npiggin@...e.de,
	jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed

> On Thu, 15 Mar 2007 01:22:45 -0400 (EDT) Ashif Harji <asharji@...uwaterloo.ca> wrote:
> I still think the simple fix of removing the 
> condition is the best approach, but I'm certainly open to alternatives.

Yes, the problem of falsely activating pages when the file is read in small
hunks is worse than the problem which your patch fixes.

We could change it so that if the current read() includes the zeroeth byte
of the page, we run mark_page_accessed() even if this_page==prev_page?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/