linux-kernel - Re: [PATCH 2/3] swsusp: Do not use page flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070315152328.228379db.akpm@linux-foundation.org>
Date:	Thu, 15 Mar 2007 15:23:28 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Kosina <jikos@...os.cz>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>, Pavel Machek <pavel@....cz>,
	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] swsusp: Do not use page flags

On Thu, 15 Mar 2007 23:19:02 +0100 (CET)
Jiri Kosina <jikos@...os.cz> wrote:

> On Thu, 15 Mar 2007, Andrew Morton wrote:
> 
> > > > And why _does_ suspend use GFP_ATOMIC all over the place?
> > > Generally, because it cannot sleep.
> > Why not?
> 
> I guess it's simply beucase of kswapd being already frozen, so there is no 
> chance that once GFP_KERNEL allocation goes to sleep, it is going to get 
> any free pages eventually ... ?

No, things should run fine with a dead kswapd.

There are reasons why we can't call into filesystems from there, but
GFP_NOIO will ensure that and it is heaps better than GFP_ATOMIC.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/