linux-kernel - RE: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc console infrastructure for Xen console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2007 14:01:50 -0500
From:	"Huang2, Wei" <Wei.Huang2@....com>
To:	"Keir Fraser" <keir@...source.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>
cc:	xen-devel@...ts.xensource.com, "Andi Kleen" <ak@....de>,
	linux-kernel@...r.kernel.org,
	"Keir Fraser" <Keir.Fraser@...source.com>,
	"Wright" <chrisw@...s-sol.org>, virtualization@...ts.osdl.org,
	"Ingo Molnar" <mingo@...e.hu>, Chris@...p.osdl.org
Subject: RE: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc
 console infrastructure for Xen console

But it is shorter than from JFK or Newark. 

-----Original Message-----
From: xen-devel-bounces@...ts.xensource.com
[mailto:xen-devel-bounces@...ts.xensource.com] On Behalf Of Keir Fraser
Sent: Friday, March 16, 2007 6:58 AM
To: Andrew Morton; Keir Fraser
Cc: xen-devel@...ts.xensource.com; Andi Kleen;
linux-kernel@...r.kernel.org; Keir Fraser; Wright;
virtualization@...ts.osdl.org; Ingo Molnar; Chris@...p.osdl.org
Subject: Re: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc
console infrastructure for Xen console

On 16/3/07 11:41, "Andrew Morton" <akpm@...ux-foundation.org> wrote:

>> It's needed for writing data /after/ reading the consumer index that
shows
>> you have space to write. Looking through xenbus_comms.c I think all
the
>> barriers are correct except there is a spurious extra mb() in
xb_read(),
>> where there is a later rmb() which is sufficient by itself. All the
others
>> have a purpose.
>> 
> 
> If Ingo couldn't work this out from reading the code then nobody else
can,
> and we have a maintainability problem which can only be solved with
> adequate commenting.

Agreed. I've fixed up the commenting, removed the spurious mb(), and I
just
need Jeremy to merge that change into the Xen pv_ops patchset. :-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@...ts.xensource.com
http://lists.xensource.com/xen-devel




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/