linux-kernel - [PATCH 2/2] Export not_critical_when_idle feature in workqueue and use it in ondemand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070316220903.GB6109@linux-os.sc.intel.com>
Date:	Fri, 16 Mar 2007 15:09:03 -0700
From:	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
To:	Andrew Morton <akpm@...l.org>, Dave Jones <davej@...hat.com>,
	tglx@...utronix.de
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/2] Export not_critical_when_idle feature in workqueue and use it in ondemand 



Add a new not_critical_when_idle parameter to queue_delayed_work_on(). This
parameter can be used to schedule work that are 'unimportant' when
CPU is idle and can be called later, when CPU eventually comes out of idle.

Use this parameter in cpufreq ondemand governor.
 
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>

Index: linux-2.6.20/kernel/workqueue.c
===================================================================
--- linux-2.6.20.orig/kernel/workqueue.c	2007-03-16 14:51:00.000000000 -0700
+++ linux-2.6.20/kernel/workqueue.c	2007-03-16 14:51:21.000000000 -0700
@@ -271,11 +271,13 @@
  * @wq: workqueue to use
  * @dwork: work to queue
  * @delay: number of jiffies to wait before queueing
+ * @not_critical_when_idle: 1 indicates work is not critical when CPU is idle
  *
  * Returns 0 if @work was already on a queue, non-zero otherwise.
  */
 int queue_delayed_work_on(int cpu, struct workqueue_struct *wq,
-			struct delayed_work *dwork, unsigned long delay)
+			struct delayed_work *dwork, unsigned long delay,
+			int not_critical_when_idle)
 {
 	int ret = 0;
 	struct timer_list *timer = &dwork->timer;
@@ -290,7 +292,7 @@
 		timer->expires = jiffies + delay;
 		timer->data = (unsigned long)dwork;
 		timer->function = delayed_work_timer_fn;
-		add_timer_on(timer, cpu, 0);
+		add_timer_on(timer, cpu, not_critical_when_idle);
 		ret = 1;
 	}
 	return ret;
@@ -614,7 +616,7 @@
 int schedule_delayed_work_on(int cpu,
 			struct delayed_work *dwork, unsigned long delay)
 {
-	return queue_delayed_work_on(cpu, keventd_wq, dwork, delay);
+	return queue_delayed_work_on(cpu, keventd_wq, dwork, delay, 0);
 }
 EXPORT_SYMBOL(schedule_delayed_work_on);
 
Index: linux-2.6.20/drivers/cpufreq/cpufreq_ondemand.c
===================================================================
--- linux-2.6.20.orig/drivers/cpufreq/cpufreq_ondemand.c	2007-03-16 14:51:00.000000000 -0700
+++ linux-2.6.20/drivers/cpufreq/cpufreq_ondemand.c	2007-03-16 14:51:21.000000000 -0700
@@ -457,7 +457,7 @@
 	                        	dbs_info->freq_lo,
 	                        	CPUFREQ_RELATION_H);
 	}
-	queue_delayed_work_on(cpu, kondemand_wq, &dbs_info->work, delay);
+	queue_delayed_work_on(cpu, kondemand_wq, &dbs_info->work, delay, 1);
 	unlock_policy_rwsem_write(cpu);
 }
 
@@ -472,7 +472,7 @@
 	dbs_info->sample_type = DBS_NORMAL_SAMPLE;
 	INIT_DELAYED_WORK(&dbs_info->work, do_dbs_timer);
 	queue_delayed_work_on(dbs_info->cpu, kondemand_wq, &dbs_info->work,
-	                      delay);
+	                      delay, 1);
 }
 
 static inline void dbs_timer_exit(struct cpu_dbs_info_s *dbs_info)
Index: linux-2.6.20/include/linux/workqueue.h
===================================================================
--- linux-2.6.20.orig/include/linux/workqueue.h	2007-03-16 14:51:00.000000000 -0700
+++ linux-2.6.20/include/linux/workqueue.h	2007-03-16 14:51:21.000000000 -0700
@@ -170,7 +170,8 @@
 extern int FASTCALL(queue_work(struct workqueue_struct *wq, struct work_struct *work));
 extern int FASTCALL(queue_delayed_work(struct workqueue_struct *wq, struct delayed_work *work, unsigned long delay));
 extern int queue_delayed_work_on(int cpu, struct workqueue_struct *wq,
-	struct delayed_work *work, unsigned long delay);
+	struct delayed_work *work, unsigned long delay,
+	int not_critical_when_idle);
 extern void FASTCALL(flush_workqueue(struct workqueue_struct *wq));
 
 extern int FASTCALL(schedule_work(struct work_struct *work));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/