[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1174031144.13341.249.camel@localhost.localdomain>
Date: Fri, 16 Mar 2007 08:45:44 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Davide Libenzi <davidel@...ilserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [patch 6/13] signal/timer/event fds v6 - timerfd core ...
On Thu, 2007-03-15 at 17:22 -0700, Davide Libenzi wrote:
> +static void timerfd_setup(struct timerfd_ctx *ctx, int clockid, int flags,
> + const struct itimerspec *ktmr)
> +{
> + enum hrtimer_mode htmode;
> +
> + htmode = (flags & TFD_TIMER_ABSTIME) ? HRTIMER_MODE_ABS: HRTIMER_MODE_REL;
> +
> + ctx->ticks = 0;
> + ctx->texp = timespec_to_ktime(ktmr->it_value);
I know, I'm racking your nerves. texp is only used for setup. No need to
carry it in the ctx data structure. :)
> + ctx->tintv = timespec_to_ktime(ktmr->it_interval);
> + hrtimer_init(&ctx->tmr, clockid, htmode);
> + ctx->tmr.expires = ctx->texp;
> + ctx->tmr.function = timerfd_tmrproc;
> + if (ctx->texp.tv64 != 0)
> + hrtimer_start(&ctx->tmr, ctx->texp, htmode);
> +}
Thanks,
tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists