linux-kernel - Re: [PATCH] i386: Simplify smp_call_function*() by using common implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070316083252.GA21418@elte.hu>
Date:	Fri, 16 Mar 2007 09:32:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, ak@...e.de,
	linux-kernel@...r.kernel.org, eranian@....hp.com,
	rdunlap@...otime.net, Jan Beulich <jbeulich@...ell.com>
Subject: Re: [PATCH] i386: Simplify smp_call_function*() by using common implementation


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Subject: Simplify smp_call_function*() by using common implementation
> 
> smp_call_function and smp_call_function_single are almost complete 
> duplicates of the same logic.  This patch combines them by 
> implementing them in terms of the more general 
> smp_call_function_mask().

> +	/* Send a message to other CPUs */
> +	if (cpus_equal(mask, allbutself))
> +		send_IPI_allbutself(CALL_FUNCTION_VECTOR);
> +	else
> +		send_IPI_mask(mask, CALL_FUNCTION_VECTOR);

this is a bit ugly, but i guess we cannot do much about it - the 
hardware side handles this in a bit assymetric way too.

Acked-by: Ingo Molnar <mingo@...e.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/