linux-kernel - RE: [git patches] libata fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00b701c768ca$a3919ca0$2101a8c0@donald>
Date:	Sat, 17 Mar 2007 20:29:53 +0100
From:	"Paul Rolland" <rol@...917.net>
To:	"'Alan Cox'" <alan@...hat.com>
Cc:	"'Tejun Heo'" <htejun@...il.com>,
	"'Linus Torvalds'" <torvalds@...ux-foundation.org>,
	"'Jeff Garzik'" <jeff@...zik.org>,
	"'Andrew Morton'" <akpm@...ux-foundation.org>,
	<linux-ide@...r.kernel.org>,
	"'LKML'" <linux-kernel@...r.kernel.org>,
	"'Eric D. Mudama'" <edmudama@...il.com>
Subject: RE: [git patches] libata fixes

Hello,

> Please match the firmware version as well for the Maxtor drives
Ok.
 
> > --- linux-2.6.21-rc4/drivers/ata/libata-core.c  2007-03-17 
> 19:29:45.000000000
> > +0100
> > +++ linux-2.6.21-rc4-Maxtor/drivers/ata/libata-core.c   2007-03-17
> > 19:37:28.000000000 +0100
> > @@ -3359,6 +3359,8 @@
> >          { "WDC WD740ADFD-00",   NULL,          ATA_HORKAGE_NONCQ },
> >         /* http://thread.gmane.org/gmane.linux.ide/14907 */
> >         { "FUJITSU MHT2060BH",  NULL,           ATA_HORKAGE_NONCQ },
> > +       /* NCQ is broken */
> > +       { "Maxtor 6L250S0",     NULL,           
> ATA_HORKAGE_NONCQ }, 
> >  
> >         /* Devices with NCQ limits */
> >  
> > 
> > Signed-off-by: Paul Rolland <rol@...917.net>
> 
> NAK - but add the firmware to the match and you can have an Ack 8)

Second try, compiled _and_ boot tested, of course.

dmesg says :
ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
ata1.00: ATA-7: Maxtor 6L250S0, BANC1G10, max UDMA/133
ata1.00: 490234752 sectors, multi 0: LBA48 NCQ (not used)
ata1.00: configured for UDMA/133

--- linux-2.6.21-rc4/drivers/ata/libata-core.c  2007-03-17 19:47:49.000000000
+0100
+++ linux-2.6.21-rc4-Maxtor/drivers/ata/libata-core.c   2007-03-17
20:24:01.000000000 +0100
@@ -3359,6 +3359,8 @@
         { "WDC WD740ADFD-00",   NULL,          ATA_HORKAGE_NONCQ },
        /* http://thread.gmane.org/gmane.linux.ide/14907 */
        { "FUJITSU MHT2060BH",  NULL,           ATA_HORKAGE_NONCQ },
+       /* NCQ is broken */
+       { "Maxtor 6L250S0",     "BANC1G10",     ATA_HORKAGE_NONCQ }, 
 
        /* Devices with NCQ limits */

Signed-off-by: Paul Rolland <rol@...917.net>

Regards,
Paul

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/