linux-kernel - Re: sysfs_drop_dentry(): possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200703191109.57683.oliver@neukum.org>
Date:	Mon, 19 Mar 2007 11:09:56 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Maneesh Soni <maneesh@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: sysfs_drop_dentry(): possible NULL dereference

Am Montag, 19. März 2007 10:22 schrieb Adrian Bunk:

>  void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent)
>  {
>         struct dentry * dentry = sd->s_dentry;
> +       struct inode *inode;
>  
>         if (dentry) {
>                 spin_lock(&dcache_lock);
>                 spin_lock(&dentry->d_lock);
>                 if (!(d_unhashed(dentry) && dentry->d_inode)) {
> +                       inode = dentry->d_inode;
> +                       spin_lock(&inode->i_lock);
> ...
> 
> <--  snip  -->
> 
> If (!dentry->d_inode), then it's a NULL dereference.

As far as I can tell, sysfs being a virtual filesystem, does not use
dentries without inodes associated.

	Regards
		Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/