lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200703191213.19652.dada1@cosmosbay.com>
Date:	Mon, 19 Mar 2007 12:13:19 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH, take2] getrusage() : Fill ru_inblock and ru_oublock fields if possible

On Monday 19 March 2007 11:53, Oleg Nesterov wrote:
> On 03/19, Eric Dumazet wrote:
> > +static inline unsigned long task_io_get_inblock(const struct task_struct
> > *p) +{
> > +	return p->ioac.read_bytes >> 9;
> > +}
> >
> > [...snip...]
> >
> > @@ -2021,6 +2022,8 @@ static void k_getrusage(struct task_stru
> >  			r->ru_nivcsw = p->signal->cnivcsw;
> >  			r->ru_minflt = p->signal->cmin_flt;
> >  			r->ru_majflt = p->signal->cmaj_flt;
> > +			r->ru_inblock = p->signal->cinblock;
> > +			r->ru_oublock = p->signal->coublock;
> >
> >  			if (who == RUSAGE_CHILDREN)
> >  				break;
> > @@ -2032,6 +2035,8 @@ static void k_getrusage(struct task_stru
> >  			r->ru_nivcsw += p->signal->nivcsw;
> >  			r->ru_minflt += p->signal->min_flt;
> >  			r->ru_majflt += p->signal->maj_flt;
> > +			r->ru_inblock += task_io_get_inblock(p->signal);
>
> p->signal is "struct signal_struct *", not "struct task_struct *" as
> task_io_get_inblock() expects ?

Me wonder how I can be sooo stupid this morning !

I submit 'take3' after some coffee... thank you Oleg

(BTW, I am going to switch from kmail to sylpheed because this damn mailer is 
too clever for me)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ