linux-kernel - Re: Geode cs5530a magic (Was: Re: [PATCH] clean up mach_reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1vegxxpa0.fsf@ebiederm.dsl.xmission.com>
Date:	Mon, 19 Mar 2007 08:48:39 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andi Kleen <ak@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Jaya Kumar <jayalk@...works.biz>
Subject: Re: Geode cs5530a magic (Was: Re: [PATCH] clean up mach_reboot_fixups)

Jeremy Fitzhardinge <jeremy@...p.org> writes:

> Andi Kleen wrote:
>> On Wednesday 14 March 2007 23:24, Jeremy Fitzhardinge wrote:
>>   
>>> The reboot_fixups stuff seems to be a bit of a mess, specifically the
>>> header is in linux/ when its a purely i386-specific piece of code.  I'm
>>> not sure why it has its config option; its only currently needed for
>>> "geode-gx1/cs5530a", so perhaps whatever config option controls that
>>> hardware should enable this?
>>>     
>>
>> Thanks. Looks good.
>
> It looks like a cs5530a is a PATA driver in drivers/ata/pata_cs5530.c. 
> Seems to me the cleanest fix is to register a reboot notifier in the
> driver and have it do the magic rather than have the special
> mach_reboot_fixups mechanism at all.
>
> Assuming it needs to be done at all...
>
> Alan? Jaya?

I'm guessing rather it is an embedded setup, then a weird pata thing.

If we want to remove crud from this path we should provide a hook like
pm_power_off to handle the reboot case.

This is not the kind of thing that a reboot notifier can be used for.
as: 
a) reboot notifiers don't get called on all paths to machine_emergency_restart.
b) touching those bits looks like they immediately flip the reset line, so
   trigger the reboot immediately.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/