linux-kernel - Re: [PATCH][5/5][resend] floppy.c: Fix device_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a8748490703190816w2f4bc4b5je8d5c17d232f15c9@mail.gmail.com>
Date:	Mon, 19 Mar 2007 16:16:24 +0100
From:	"Jesper Juhl" <jesper.juhl@...il.com>
To:	"Andi Kleen" <ak@...e.de>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Trent Waddington" <trent.waddington@...il.com>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

On 19/03/07, Andi Kleen <ak@...e.de> wrote:
>
> >
> > -             device_create_file(&floppy_device[drive].dev,&dev_attr_cmos);
> > +             err = device_create_file(&floppy_device[drive].dev, &dev_attr_cmos);
> > +             if (err)
> > +                     printk(KERN_WARNING "Unable to create sysfs attribute "
> > +                             "file for floppy device: %s\n",
> > +                             floppy_device[drive].name);
>
> That change looks pretty useless. Either the error should be handled correctly
> by bailing out or the warn_unused_results should be dropped.
>
At least letting the user know that something failed is better than
the current situation of just failing silently I'd say.

-- 
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/