linux-kernel - drivers/message/fusion/mptsas.c: inconsequent NULL checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070319092449.GM752@stusta.de>
Date:	Mon, 19 Mar 2007 10:24:49 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Eric.Moore@....com
Cc:	mpt_linux_developer@....com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: drivers/message/fusion/mptsas.c: inconsequent NULL checking

The Coverity checker spotted the following inconsequent NULL checking in
drivers/message/fusion/mptsas.c:

<--  snip  -->

...
static void
mptsas_delete_expander_phys(MPT_ADAPTER *ioc)
{
...
                if (port_info->phy_info &&
                    (!(port_info->phy_info[0].identify.device_info &
                    MPI_SAS_DEVICE_INFO_SMP_TARGET)))
                        continue;

                if (mptsas_sas_expander_pg0(ioc, &buffer,
                     (MPI_SAS_EXPAND_PGAD_FORM_HANDLE <<
                     MPI_SAS_EXPAND_PGAD_FORM_SHIFT),
                     port_info->phy_info[0].handle)) {
...

<--  snip  -->

port_info->phy_info is first checked but later dereferenced 
unconditionally.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/