linux-kernel - Re: "reboot" swsusp mode leaves moon icon blinking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070320165058.GA15888@leiferikson>
Date:	Tue, 20 Mar 2007 17:50:59 +0100
From:	Johannes Weiner <hannes-kernel@...urebad.de>
To:	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: "reboot" swsusp mode leaves moon icon blinking

Hi,

On Tue, Mar 20, 2007 at 01:32:45PM +0100, Pavel Machek wrote:
> Date: Tue, 20 Mar 2007 13:32:45 +0100
> From: Pavel Machek <pavel@....cz>
> To: "Rafael J. Wysocki" <rjw@...k.pl>,
> 	kernel list <linux-kernel@...r.kernel.org>
> Cc: Andrew Morton <akpm@...l.org>
> Subject: "reboot" swsusp mode leaves moon icon blinking
> 
> Hi!
> 
> ...and cause is really simple.
> 
> During resume, we do not know that "reboot" method was used, so we
> assume plaform and make the led blink...

What does the "reboot" swsusp mean?

I am having this (or a similar problem):

	echo shutdown > /sys/power/disk; echo disk > /sys/power/state

suspends normally.  But after a resume, the moon keeps blinking _and_
I don't get ACPI events anymore.  At least all ibm-acpi features refuse
to work (hotkeys, lcd-brightness, lid, ...).

I saved some /proc files (interrupts, acpi/processor/power, ...) and
compared them before the suspend and after the resume but I could not
find any differences.

> diff --git a/kernel/power/disk.c b/kernel/power/disk.c
> index 873cdf8..dee0ff4 100644
> --- a/kernel/power/disk.c
> +++ b/kernel/power/disk.c
> @@ -241,18 +241,11 @@ static int software_resume(void)
>  		goto Done;
>  	}
>  
> -	error = platform_prepare();
> -	if (error) {
> -		swsusp_free();
> -		goto Thaw;
> -	}
> -

What is platform_prepare() actually good for when _resuming_? I tried to
follow the function calls and it seems to disable a lot of thing instead
of re-enabling them...?

=Hannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/