linux-kernel - Re: Bug in pci_restore_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Mar 2007 22:07:59 +0100
From:	Thomas Meyer <thomas@...3r.de>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
CC:	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: Bug in pci_restore_msi_state

Pekka Enberg schrieb:
> On 3/17/07, Thomas Meyer <thomas@...3r.de> wrote:
>> Hello everybody.
>>
>> I get this bug after suspending to disk twice:
>>
>> http://m3y3r.de/bilder/Bug-pci_restore_msi_state.png
>>
>> This happens with current git head
>> cd05a1f818073a623455a58e756c5b419fc98db9.
>
> If you know a kernel that works, please consider doing git bisect:
>
> http://www.kernel.org/pub/software/scm/git/docs/howto/isolate-bugs-with-bisect.txt
>
>

Ok. The error happens in the call of pcibios_enable_device in the
function do_pci_enable_device (drivers/pci/pci.c):

Before the call of pcibios_enable_device:

do_pci_enable_device: pci_dev= c1a40000
do_pci_enable_device: irq= 218
do_pci_enable_device: msi_enabled= 1

after the call:
ACPI: PCI Interrupt 0000:00:1f.2[B] -> GSI 19 (level, low) -> IRQ 19

do_pci_enable_device: pci_dev= c1a40000
do_pci_enable_device: irq= 19
do_pci_enable_device: msi_enabled= 1


So the function acpi_pci_irq_enable in drivers/acpi/pci_irq.c  needs to
be fixed:

a.) acpi_pci_irq_enable should care about msi setups and set the flag
msi_enabled to 0 or
b.) acpi_pci_irq_enable should care about msi setups and should touch
the dev->irq field.

Please comment on this.

with kind regards
thomas


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/