linux-kernel - [PATCH 2.6.21-rc4] ieee1394: fix oops on "modprobe -r ohci1394" after network class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tkrat.5965dca5154c0fa2@s5r6.in-berlin.de>
Date:	Tue, 20 Mar 2007 22:43:22 +0100 (CET)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux-kernel@...r.kernel.org, linux1394-devel@...ts.sourceforge.net
cc:	Ismail Dönmez <ismail@...dus.org.tr>,
	Adrian Bunk <bunk@...sta.de>, Greg KH <greg@...ah.com>,
	Thomas Meyer <thomas@...3r.de>,
	Tobias Diedrich <ranma@...edrich.de>
Subject: [PATCH 2.6.21-rc4] ieee1394: fix oops on "modprobe -r ohci1394" after
 network class_device conversion

The networking subsystem has been converted from class_device to device
but ieee1394 hasn't.  This results in a 100% reproducible NULL pointer
dereference if the ohci1394 driver module is unloaded while the eth1394
module is still loaded.
http://lkml.org/lkml/2006/11/16/147
http://lkml.org/lkml/2007/3/14/4

This is a regression in 2.6.21-rc1.

Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
---

Works for me.  I still can connect to an OS X box via eth1394 after that
and modprobe -r ohci1394 before modprobe -r eth1394 works again.

Index: linux-2.6.21-rc4/drivers/ieee1394/eth1394.c
===================================================================
--- linux-2.6.21-rc4.orig/drivers/ieee1394/eth1394.c	2007-03-16 19:24:44.000000000 +0100
+++ linux-2.6.21-rc4/drivers/ieee1394/eth1394.c	2007-03-20 22:28:49.000000000 +0100
@@ -586,7 +586,10 @@ static void ether1394_add_host (struct h
         }
 
 	SET_MODULE_OWNER(dev);
+#if 0
+	/* FIXME - Is this the correct parent device anyway? */
 	SET_NETDEV_DEV(dev, &host->device);
+#endif
 
 	priv = netdev_priv(dev);
 


-- 
Stefan Richter
-=====-=-=== --== =-=--
http://arcgraph.de/sr/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/