linux-kernel - Re: [PATCH 2.6.22 3/3] Add LED trigger to libata core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45FF5749.6010407@gmail.com>
Date:	Tue, 20 Mar 2007 12:38:49 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Tony Vroon <chainsaw@...too.org>
CC:	Jeff Garzik <jgarzik@...ox.com>, alan@...rguk.ukuu.org.uk,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.22 3/3] Add LED trigger to libata core

Tony Vroon wrote:
> The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/
> Apple K2 driver. Used by the IDE LED trigger on G5 towers.
> Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox.

Just two comments.

1. IMHO, ata_qc_issue_prot_ledtrigger() without 'with' is good enough. 
This is just my personal preference.  Feel free to ignore it.

2. Patch #1 and #2 should be merged.  They're one logical change of 
adding ata_qc_issue_prot_with_ledtrigger().  Patch #3 is a logically 
separate change of using it, but unless it's a wide conversion, 
implementing something and using something can be merged.  So, please 
merge #1 and #2 and possibly #3.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/