linux-kernel - Re: [patch 2/13] signal/timer/event fds v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070320002205.GA338@tv-sign.ru>
Date:	Tue, 20 Mar 2007 03:22:05 +0300
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Davide Libenzi <davidel@...ilserver.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [patch 2/13] signal/timer/event fds v7 - signalfd core ...

On 03/19, Davide Libenzi wrote:
>
> +static void signalfd_unlock(struct signalfd_ctx *ctx,
> +			    struct signalfd_lockctx *lk)
> +{
> +	unlock_task_sighand(lk->tsk, &lk->flags);
> +}

Again, this is a matter of taste. But I can't understand why signalfd_unlock()
needs "signalfd_ctx *ctx" parameter. If we have "struct signalfd_lockctx *lk",
signalfd_lock() can setup lk->ctx if it is ever needed.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/