linux-kernel - Re: Suspend to disk bug 2.6.21-rc2-git1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Mar 2007 23:39:08 +0100
From:	Pavel Machek <pavel@....cz>
To:	Lukas Hejtmanek <xhejtman@...l.muni.cz>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Suspend to disk bug 2.6.21-rc2-git1

Hi!

> > > I'm not sure what version did exacly caused susped to disk problems but
> > > anyway, in 2.6.21-rc2-git1, suspend to disk breaks ACPI. ACPI events do not
> > > even emit ACPI interrupts. Suspend to ram works nicely.
> > 
> > Is 2.6.21-latest better?  There were many problems in suspend area,
> > hopefully they are slowly being fixed...
> 
> I've found out that only platform method is working. reboot method does not.

Try this one.
									Pavel

Fix reboot mode blinking moon icon after resume.

---
commit 5958dbea2ea6147f4fd0477b303be752d5c4f53a
tree 9c032e050d09201f66e1706fef4d7bbe8e55c418
parent 2744ccbdcc03f36d193fe20fc17698cfb2a1acea
author Pavel <pavel@....ucw.cz> Tue, 20 Mar 2007 16:33:03 +0100
committer Pavel <pavel@....ucw.cz> Tue, 20 Mar 2007 16:33:03 +0100

 kernel/power/disk.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index 873cdf8..dee0ff4 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -241,18 +241,11 @@ static int software_resume(void)
 		goto Done;
 	}
 
-	error = platform_prepare();
-	if (error) {
-		swsusp_free();
-		goto Thaw;
-	}
-
 	pr_debug("PM: Reading swsusp image.\n");
 
 	error = swsusp_read();
 	if (error) {
 		swsusp_free();
-		platform_finish();
 		goto Thaw;
 	}
 
@@ -270,7 +263,6 @@ static int software_resume(void)
 	enable_nonboot_cpus();
  Free:
 	swsusp_free();
-	platform_finish();
 	device_resume();
 	resume_console();
  Thaw:

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/