linux-kernel - Re: [PATCH -mm 1/5] Blackfin: blackfin architecture patch update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070321234254.GA17498@linux-sh.org>
Date:	Thu, 22 Mar 2007 08:42:54 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	"Wu, Bryan" <bryan.wu@...log.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 1/5] Blackfin: blackfin architecture patch update

On Wed, Mar 21, 2007 at 11:44:27AM -0400, Mike Frysinger wrote:
> On 3/5/07, Paul Mundt <lethal@...ux-sh.org> wrote:
> >> +int __init oprofile_arch_init(struct oprofile_operations *ops)
> >> +{
> >> +#ifdef CONFIG_HARDWARE_PM
> >[snip]
> >> +#else
> >> +     return -1;
> >> +#endif
> >> +}
> >
> >Uh.. fix your dependencies.
> 
> can you elaborate ?

This code does nothing if CONFIG_HARDWARE_PM isn't enabled, so your best
bet is to simply have an op_model_null for the cases where you can't
support the counters and work out the dependencies in the Makefile.
Trying to hack both of these together in one driver is not the way to go.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/