linux-kernel - Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4600DF90.3030902@gmail.com>
Date:	Wed, 21 Mar 2007 16:32:32 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	Robert Hancock <hancockr@...w.ca>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	"Eric D. Mudama" <edmudama@...il.com>, Mathieu.Berard@...ns.org
Subject: Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image
 Windows driver

Jeff Garzik wrote:
> Robert Hancock wrote:
>> This patch adds in some NCQ blacklist entries taken from the Silicon
>> Image Windows drivers' .inf files for the 3124 and 3132 controllers.
>> These entries were marked as ""DisableSataQueueing". Assume these are
>> in their blacklist for a reason and disable NCQ on these drives.
>>
>> Signed-off-by: Robert Hancock <hancockr@...w.ca>
>>
>> --- linux-2.6.21-rc1edit/drivers/ata/libata-core.c.prev    2007-02-21
>> 22:23:05.000000000 -0600
>> +++ linux-2.6.21-rc1edit/drivers/ata/libata-core.c    2007-02-21
>> 22:25:44.000000000 -0600
>> @@ -3269,6 +3269,13 @@ static const struct ata_blacklist_entry
>>     /* Devices with NCQ limits */
>>
>> +    /* The following blacklist entries are taken from the Windows
>> +       driver .inf files for the Silicon Image 3124 and 3132. */
>> +    { "Maxtor 7B250S0",    "BANC1B70",    ATA_HORKAGE_NONCQ, },
>> +    { "HTS541060G9SA00",    "MB3OC60D",    ATA_HORKAGE_NONCQ, },
>> +    { "HTS541080G9SA00",    "MB4OC60D",    ATA_HORKAGE_NONCQ, },
>> +    { "HTS541010G9SA00",    "MBZOC60D",    ATA_HORKAGE_NONCQ, },

There was a recent regression report on ahci + HTS541010G9SA00 from
Mathieu Berard (cc'd).  NCQ + device initiated link power saving (which,
BTW, got activated by executing _GTF.  surprise!) combination seems
broken.  I know that ahci controllers (at least ich6m, ich7 and ich8)
work with device initiated PS, so it's most likely the disk that's
malfunctioning.

This and the fact sata_sil24 windows driver blacklists them make me
think those HTS5410s should be added to our blacklist too.  What do you
think?

Mathieu, just to be sure, can you post the result of 'hdparm -I
/dev/sdX' and 'lspci -nn'?

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/