linux-kernel - Re: [PATCH] swsusp: Fix SNAPSHOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070321083146.GC4520@elf.ucw.cz>
Date:	Wed, 21 Mar 2007 09:31:46 +0100
From:	Pavel Machek <pavel@....cz>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] swsusp: Fix SNAPSHOT_S2RAM ioctl

Hi!

> > From: Rafael J. Wysocki <rjw@...k.pl>
> > 
> > The SNAPSHOT_S2RAM ioctl does not disable the nonboot CPUs before entering
> > the suspend, although it should do this.
> > 
> > --- linux-2.6.21-rc4.orig/kernel/power/user.c
> > +++ linux-2.6.21-rc4/kernel/power/user.c
> > @@ -374,9 +374,12 @@ static int snapshot_ioctl(struct inode *
> >  		if (error) {
> >  			printk(KERN_ERR "Failed to suspend some devices.\n");
> >  		} else {
> > -			/* Enter S3, system is already frozen */
> > -			suspend_enter(PM_SUSPEND_MEM);
> > -
> > +			error = disable_nonboot_cpus();
> > +			if (!error) {
> > +				/* Enter S3, system is already frozen */
> > +				suspend_enter(PM_SUSPEND_MEM);
> > +				enable_nonboot_cpus();
> > +			}
> >  			/* Wake up devices */
> >  			device_resume();
> >  		}
> 
> Do you consider this appropriate to 2.6.21?

Yes, this one is.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/