linux-kernel - Problem with fix-rmmod-read-write-races-in-proc-entries.patch in 2.6.21-rc4-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070322091445.0eecd44f.dada1@cosmosbay.com>
Date:	Thu, 22 Mar 2007 09:14:45 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Alexey Dobriyan <adobriyan@...ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Problem with fix-rmmod-read-write-races-in-proc-entries.patch in
 2.6.21-rc4-mm1

Hi Alexey,

It seems you are fix-rmmod-read-write-races-in-proc-entries.patch author ?

/proc/kcore is no longer seekable (or mappable)

Also, do we really need to proxy via proc_reg_file_ops files that are not provided by a module ?

I think not.

Could you please add in proc_get_inode() a check against de->proc_fops->owner ?

if (de->proc_fops) {
#ifdef CONFIG_MODULE
    if (S_ISREG(inode->i_mode) && de->proc_fops->owner)
        inode->i_fop = &proc_reg_file_ops;
    else
#endif
        inode->i_fop = de->proc_fops;
}

Maybe the whole proc_reg_XXX() functions could be omitted for a kernel without module support ?

Thank you
Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/