linux-kernel - Re: [PATCH 0/21] MSI rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1lkhp8gqx.fsf@ebiederm.dsl.xmission.com>
Date:	Thu, 22 Mar 2007 09:01:10 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	linux-pci@...ey.karlin.mff.cuni.cz,
	Greg Kroah-Hartman <greg@...ah.com>,
	"David S. Miller" <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	<linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	<daniel.e.wolstenholme@...el.com>
Subject: Re: [PATCH 0/21] MSI rework

Michael Ellerman <michael@...erman.id.au> writes:

> This is my series to rework the generic MSI code into something we can use
> on powerpc[1].
>
> I've tried as much as possible not to change the semantics for other archs,
> but there's a few little changes. I think they're all OK in their own right.
>
> I don't have any serious hardware to test on, but my little x86_64 box with
> an e1000 using MSI still works with these changes. I've also got MSI working
> on a powerpc blade with a tg3. I haven't tested MSI-X _at all_.
>
> I've also tested on the blade with a debug hack to make the MSI case
> allocate/free 8 MSIs, but only use the last one, just to exercise the n > 1
> case a little. All seems to work fine.

Generally I think this looks good.  However there is a lot here, and some
of it potentially at least has some pretty subtle side effects.

So reviewing all of these patches at once is almost certain to cause
something important to be missed :(

Can we slow this process down a few days by taking this one logical chunk
at a time?

i.e.  First the simple bug fixes that should purely be restructure of
msi.c with no affect on anything outside of it.

And then get into the architecture enhancements.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/