linux-kernel - Re: [linux-pm] [patch 2/2] clk_must

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070323122158.GE9667@elf.ucw.cz>
Date:	Fri, 23 Mar 2007 13:21:58 +0100
From:	Pavel Machek <pavel@....cz>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-pm@...ts.linux-foundation.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Andrew Victor <andrew@...people.com>
Subject: Re: [linux-pm] [patch 2/2] clk_must_disable() implementation on AT91

Hi!

> This supports the new clk_must_disable() interface for AT91 systems:
> 
>  - Implement the call, replacing at91_suspend_entering_slow_clock()
>    and eliminating various "that's not exported" build warnings;
> 
>  - Use it in three drivers: USB Host, USB Peripheral, and RS232 serial.
> 
> Briefly, those are three of the drivers that need to act differently when
> going into deeper sleep states (suspend-to-RAM, vs standby), since among
> other things they can't act as wakeup event sources without using the
> clocks which are disabled in those deeper sleep states.
> 
> (The at91_ethernet driver would be another such driver, but it doesn't
> currently implement wake-on-LAN even in the "standby" mode.)
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>

FWIW, it looks okay to me. But you probably need to cc akpm if you
want it merged...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/