linux-kernel - Re: [patch] cache pipe buf page address for non-highmem arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070322170122.ee2589a1.akpm@linux-foundation.org>
Date:	Thu, 22 Mar 2007 17:01:22 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Ken Chen" <kenchen@...gle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch] cache pipe buf page address for non-highmem arch

On Thu, 22 Mar 2007 17:51:11 -0700 "Ken Chen" <kenchen@...gle.com> wrote:

> +#ifdef CONFIG_HIGHMEM
> +#define pipe_kmap		kmap
> +#define pipe_kmap_atomic	kmap_atomic
> +#else	/* CONFIG_HIGHMEM */
> +static inline void *pipe_kmap(struct page *page)
> +{
> +	return (void *) page->private;
> +}
> +static inline void *pipe_kmap_atomic(struct page *page, enum km_type type)
> +{
> +	pagefault_disable();
> +	return pipe_kmap(page);
> +}
> +#endif

If we're going to do this then we should also implement pipe_kunmap_atomic().
Relying upon kunmap_atomic() internals like this is weird-looking, and is fragile
against future changes to kunmap_atomic().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/