linux-kernel - Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file linux/dvb/version.h.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1174665764.1158.241.camel@laptopd505.fenrus.org>
Date:	Fri, 23 Mar 2007 17:02:44 +0100
From:	Arjan van de Ven <arjan@...radead.org>
To:	Marcel Siegert <mws@...uxtv.org>
Cc:	v4l-dvb-maintainer@...uxtv.org,
	"Robert P. J. Day" <rpjday@...dspring.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header file
	linux/dvb/version.h.

On Fri, 2007-03-23 at 16:47 +0100, Marcel Siegert wrote:
> On Friday 23 March 2007, Robert P. J. Day wrote:
> > 
> > Delete the unreferenced header file include/linux/dvb/version.h.
> > 
> > Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
> > 
> NACK
> this header is unreferenced in kernel, but used for applications that compile for userspace
> to determine the api version.


btw that is something extremely evil to do. Either you have varying apis
between kernels (which is naughty, but I suppose you can go up in
capabilities) or it's fully static. 

If it's dynamic, doing it compiletime is BAD. The same binaries should
run on multiple kernels after all. An ioctl or a sysfs thing or
something is a lot better than a compile time constant.

If it's entirely static exposing a "version" doesn't mean anything and
it might as well be killed...

Greetings,
   Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/