[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070323214704.1e8d5463@lxorguk.ukuu.org.uk>
Date: Fri, 23 Mar 2007 21:47:04 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Randy Dunlap <randy.dunlap@...cle.com>
Cc: linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
kyle@...onical.com
Subject: Re: HPA patches
> > > What is 0x40? can it be #defined (or enum-ed) instead of a magic
> > > value? please? (more of same below)
> >
> > It's 0x40. Its a "command dependant bit" - no useful name.
>
> dependent. OK, thanks.
IDE is a bit like that. I'm amazed some of the command flags arent in
latin.
> Already corrected (printk types). And putting
> hpa_sectors);
> on a separate line doesn't hurt readability.
Maybe
Thanks for looking over the diff.
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists