linux-kernel - Re: apm.c: get rid of unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070325162505.GN16477@stusta.de>
Date:	Sun, 25 Mar 2007 18:25:05 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	Parag Warudkar <parag.warudkar@...il.com>
Cc:	linux-kernel@...r.kernel.org, sfr@...b.auug.org.au,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	John Stultz <johnstul@...ibm.com>
Subject: Re: apm.c: get rid of unused variables

On Sun, Mar 25, 2007 at 12:06:19PM -0400, Parag Warudkar wrote:
> 
> The patch below (against latest git) gets rid of following unused 
> variables - clock_cmos_diff and got_clock_diff.
> 
> 2 less compiler warnings.
> 
> Compile tested on i386.
> 
> Signed-off-by: Parag Warudkar <parag.warudkar@...il.com>
> 
> --- linux-2.6/arch/i386/kernel/apm.c	2007-03-24 21:43:35.000000000 -0400
> +++ linux-2.6-wk/arch/i386/kernel/apm.c	2007-03-25 
> 11:50:16.000000000 -0400
> @@ -384,13 +384,6 @@
>  static int			ignore_normal_resume;
>  static int			bounce_interval __read_mostly = 
>  DEFAULT_BOUNCE_INTERVAL;
> 
> -#ifdef CONFIG_APM_RTC_IS_GMT
> -#	define	clock_cmos_diff	0
> -#	define	got_clock_diff	1
> -#else
> -static long			clock_cmos_diff;
> -static int			got_clock_diff;
> -#endif
>  static int			debug __read_mostly;
>  static int			smp __read_mostly;
>  static int			apm_disabled = -1;

You could also remove the APM_RTC_IS_GMT config option.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/