linux-kernel - Re: [PATCH 1/2] MSR: Add support for safe variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070325142215.eff3af8f.akpm@linux-foundation.org>
Date:	Sun, 25 Mar 2007 14:22:15 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Rudolf Marek <r.marek@...embler.cz>,
	Alexey Dobriyan <adobriyan@...nvz.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: [PATCH 1/2] MSR: Add support for safe variants

On Sun, 25 Mar 2007 14:18:23 +0200 Jean Delvare <khali@...ux-fr.org> wrote:

> Add support for _safe (exception handled) variants of rdmsr_on_cpu 
> and wrmsr_on_cpu.  This is needed for the upcoming coretemp hardware
> monitoring driver, which might step into non-existing (poorly
> documented) MSR.

Crappy changelog.  What do these functions do?  What is "safe" about them? 
This is described in neither the changelog nor the code comments, but it
should be described in both.

Also, Andi presently has several MSR patches queued (most prominently
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/patches/rwmsr-on-cpu)
but I'm not including them in -mm due to rejects.  If I get a properly
changlogged and commented version of this patch I can merge it, but it
might get wrecked again when the x86_64 tree gets sorted out.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/