linux-kernel - Re: [PATCH] max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b040c32a0703241729w9586ea2m7481f6b8cf3d24d2@mail.gmail.com>
Date:	Sat, 24 Mar 2007 17:29:38 -0700
From:	"Ken Chen" <kenchen@...gle.com>
To:	"Jan Engelhardt" <jengelh@...ux01.gwdg.de>
Cc:	"Eric Dumazet" <dada1@...mosbay.com>, "Tomas M" <tomas@...x.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] max_loop limit

On 3/23/07, Jan Engelhardt <jengelh@...ux01.gwdg.de> wrote:
> @@ -1383,7 +1380,7 @@ int loop_unregister_transfer(int number)
>
>         xfer_funcs[n] = NULL;
>
> -       for (lo = &loop_dev[0]; lo < &loop_dev[max_loop]; lo++) {
> +       list_for_each_entry(lo, &loop_devices, lo_list) {
>                 mutex_lock(&lo->lo_ctl_mutex);

Don't you need to use loop_devices_lock to protect the linked list here?


> +static struct loop_device *loop_find_dev(unsigned int number)
> +{
> +       struct loop_device *lo;
> +       list_for_each_entry(lo, &loop_devices, lo_list)
> +               if (lo->lo_number == number)
> +                       return lo;
> +       return NULL;

Here too with spin lock??
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/