linux-kernel - Re: [ckrm-tech] [PATCH 1/7] containers (V7): Generic container system abstracted from cpusets code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070324184128.e8b34a3e.pj@sgi.com>
Date:	Sat, 24 Mar 2007 18:41:28 -0700
From:	Paul Jackson <pj@....com>
To:	vatsa@...ibm.com
Cc:	sekharan@...ibm.com, ckrm-tech@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, xemul@...ru, dev@...ru,
	rohitseth@...gle.com, ebiederm@...ssion.com, mbligh@...gle.com,
	winget@...gle.com, containers@...ts.osdl.org, serue@...ibm.com,
	menage@...gle.com, devel@...nvz.org
Subject: Re: [ckrm-tech] [PATCH 1/7] containers (V7): Generic container
 system abstracted from cpusets code

vatsa wrote:
> >         if (tsk->flags & PF_EXITING) {
> 
> What if PF_EXITING is set after this check? If that happens then,
> 
> >                 task_unlock(tsk);
> >                 mutex_unlock(&callback_mutex);
> >                 put_task_struct(tsk);
> >                 return -ESRCH;
> >         }
> 
> the following code becomes racy with cpuset_exit() ...
> 
>         atomic_inc(&cs->count);
>         rcu_assign_pointer(tsk->cpuset, cs);
>         task_unlock(tsk);

eh ... so ... ?

I don't know of any sequence where that causes any problem.

Do you see one?

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/