linux-kernel - Re: -rc5: e1000 resume weirdness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4607ECDE.3030803@intel.com>
Date:	Mon, 26 Mar 2007 08:55:10 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Jesse Brandeburg <jesse.brandeburg@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...sta.de>
Subject: Re: -rc5: e1000 resume weirdness

Jesse Brandeburg wrote:
> On 3/26/07, Ingo Molnar <mingo@...e.hu> wrote:
>> hm, on a T60, after suspend/resume, i get an e1000 timeout:
>>
>> e1000: eth0: e1000_watchdog: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
>> e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
>>   Tx Queue             <0>
>>   TDH                  <ec>
>>   TDT                  <ec>
>>   next_to_use          <ec>
>>   next_to_clean        <82>
>> buffer_info[next_to_clean]
>>   time_stamp           <fffcc3db>
>>   next_to_watch        <82>
>>   jiffies              <fffd5da0>
>>   next_to_watch.status <1>
>>
>> it works fine after that reset. The e1000 driver didnt do this before
>> after resume the network was always available immediately. So this
>> appears to be a relatively new regression (post-rc3 or so). high-res
>> timers was disabled.
> 
> was there a "NETDEV WATCHDOG" message that follows this?  If not it is
> a harmless debug print.  Note the time_stamp and jiffies difference,
> very large, consistent with a resume.  I think we need to disable the
> internal e1000 tx hang code that causes this debug print when we are
> suspending.  I'll work with auke to generate a short patch.

hmm, yeah, it appears that the patch I sent just a second ago isn't applicable 
in this case, since the irq handler is obviously enabled (the Link Up message 
proves that).

thanks to Jesse for being awake :)


Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/