linux-kernel - Re: [PATCH -mm] Blackfin arch: add kdebug header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703262345.09489.arnd@arndb.de>
Date:	Mon, 26 Mar 2007 23:45:08 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	bryan.wu@...log.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Mundt <lethal@...ux-sh.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] Blackfin arch: add kdebug header file

I can see nothing wrong with your patches, but you should make the
patch descriptions a little clearer:

On Monday 26 March 2007, Wu, Bryan wrote:
> Hi folks,

No need for this line, if it's there, Andrew just needs to remove
it from the changelog.

> This patch adds kdebug.h header file to blackfin architecture.

This line is completely redundant, as it states the same information
as the subject. You should give some background information here,
like:

kdebug.h is needed for kprobes.

For trivial patches where the subject already tells the whole story
(e.g. 'remove redundant declaration of foo'), just leave out the
description entirely except for the Signed-off-by.

	Arnd <><
you can even leave out the description
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/