linux-kernel - Re: [PATCH -mm] Blackfin: spi driver cleanup and coding style fixing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200703261536.56689.david-b@pacbell.net>
Date:	Mon, 26 Mar 2007 15:36:56 -0700
From:	David Brownell <david-b@...bell.net>
To:	bryan.wu@...log.com
Cc:	dbrownell@...rs.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] Blackfin: spi driver cleanup and coding style fixing

On Monday 26 March 2007 3:14 am, Wu, Bryan wrote:
> Hi folks,
> 
> This patch cleanup blackfin SPI driver code and fix some coding style
> problems.

Good, thanks.  I'll forward the current state of my review, after
I cross-check it against these two patches.

That'll mean I need to re-start that review ... at that point it'd
be better to start with a single clean patch.


> -#ifdef DEBUG
> -#define ASSERT(expr) \
> -	if (!(expr)) { \
> -		printk(KERN_DEBUG "assertion failed! %s[%d]: %s\n", \
> -		       __FUNCTION__, __LINE__, #expr); \
> -		panic(KERN_DEBUG "%s", __FUNCTION__); \
> -	}
> -#else
> -#define ASSERT(expr)
> -#endif

Yes, that was certainly in the "remove that" category.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/