linux-kernel - Re: [PATCH] fat/vfat: optionally ignore system timezone offset when reading/writing timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fy7rrp1i.fsf@briny.internal.ondioline.org>
Date:	Tue, 27 Mar 2007 21:52:57 +1200
From:	Paul Collins <paul@...ny.ondioline.org>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	Hiroyuki Machida <Hiroyuki_Machida@...scei.sony.co.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat/vfat: optionally ignore system timezone offset when reading/writing timestamps

OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> writes:

> Hiroyuki Machida <Hiroyuki_Machida@...scei.sony.co.jp> writes:
>
>> I'm not famillar with recent fat code, but code itself looks good for
>> just turn on/off time adjusting. On the other hand, I feel we need more 
>> consideration on use cases/requirements. I feel that turning off
>> time adjustment is a just ad-hoc solution to issues like Paul san 
>> brought up.
>
> Thank you. I see. So we need "timezone" option to specify adjusted
> time?  If so, I feel we can add it as "timezone=utc", then it'll can
> be improved later...

I am happy to change the patch as needed.  However, since the kernel
does not have access to a timezone database and therefore cannot
convert timezone names to offsets, perhaps the mount option should be
something like "tzoffset=0", "tzoffset=1200" etc., with "tzoffset=0"
being equivalent to the "posixtime" option implemented by my patch.

-- 
Paul Collins
Wellington, New Zealand

Dag vijandelijk luchtschip de huismeester is dood
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/