linux-kernel - Re: [-mm patch] fix arch/i386/kernel/marker.c compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070327171150.GA24349@Krystal>
Date:	Tue, 27 Mar 2007 13:11:50 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: [-mm patch] fix arch/i386/kernel/marker.c compilation

Hi Adrian,

Since kdebug.h seems to have moved from asm/ to linux/ in Andrew's tree, I
guess the #include <asm/kdebug.h> should be removed ? linux/kdebug.h
already includes asm/kdebug.h.

Mathieu

* Adrian Bunk (bunk@...sta.de) wrote:
> On Mon, Mar 26, 2007 at 08:57:06PM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.21-rc4-mm1:
> >...
> > +move-die-notifier-handling-to-common-code.patch
> >...
> >  Misc
> >...
> 
> 
> This patch fixes the following compile error:
> 
> <--  snip  -->
> 
> ...
>   CC      arch/i386/kernel/marker.o
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c: In function 'mark_notifier':
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:44: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:44: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:47: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:48: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c: In function 'marker_optimized_set_enable':
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:69: error: implicit declaration of function 'register_die_notifier'
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:87: error: implicit declaration of function 'unregister_die_notifier'
> make[2]: *** [arch/i386/kernel/marker.o] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
> 
> ---
> --- linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c.old	2007-03-27 18:46:49.000000000 +0200
> +++ linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c	2007-03-27 18:47:14.000000000 +0200
> @@ -16,6 +16,7 @@
>  #include <linux/notifier.h>
>  #include <linux/module.h>
>  #include <linux/marker.h>
> +#include <linux/kdebug.h>
>  #include <asm/cacheflush.h>
>  #include <asm/kdebug.h>
>  
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/