linux-kernel - [PATCH] aio: remove bare user-triggerable error printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070327224401.17758.17852.sendpatchset@tetsuo.zabbo.net>
Date:	Tue, 27 Mar 2007 15:44:01 -0700 (PDT)
From:	Zach Brown <zach.brown@...cle.com>
To:	linux-aio@...ck.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Jeff Moyer <jmoyer@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] aio: remove bare user-triggerable error printk

aio: remove bare user-triggerable error printk

The user can generate console output if they cause do_mmap() to fail during
sys_io_setup().  This was seen in a regression test that does exactly that by
spinning calling mmap() until it gets -ENOMEM before calling io_setup().

We don't need this printk all, just remove it.

Signed-off-by: Zach Brown <zach.brown@...cle.com>
---

 fs/aio.c |    1 -
 1 file changed, 1 deletion(-)

--- a/fs/aio.c	Tue Mar 27 14:56:08 2007 -0700
+++ b/fs/aio.c	Tue Mar 27 14:56:49 2007 -0700
@@ -136,7 +136,6 @@ static int aio_setup_ring(struct kioctx 
 				  0);
 	if (IS_ERR((void *)info->mmap_base)) {
 		up_write(&ctx->mm->mmap_sem);
-		printk("mmap err: %ld\n", -info->mmap_base);
 		info->mmap_size = 0;
 		aio_free_ring(ctx);
 		return -EAGAIN;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/