linux-kernel - Re: [PATCH 2/2] revoke: break cow for private mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 28 Mar 2007 13:09:41 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Nick Piggin" <nickpiggin@...oo.com.au>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] revoke: break cow for private mappings

On 3/28/07, Nick Piggin <nickpiggin@...oo.com.au> wrote:
> > +             ret = get_user_pages(tsk, tsk->mm, vma->vm_start,
> > +                                  vma->vm_end-vma->vm_start, 1, 1, NULL,
> > +                                  NULL);
>
> get_user_pages length argument is in # of pages, rather than address range,
> I think. vma_pages is what you want?

Yes.

On 3/28/07, Nick Piggin <nickpiggin@...oo.com.au> wrote:
> > +     up_write(&mm->mmap_sem);
>
> I think you just need down_read of mmap_sem here?

Indeed. Thanks Nick.

                                  Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/