linux-kernel - Re: question on tty open and close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <460A8941.4090405@microgate.com>
Date:	Wed, 28 Mar 2007 09:26:57 -0600
From:	Paul Fulghum <paulkf@...rogate.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Stuart MacDonald <stuartm@...necttech.com>,
	"'Oliver Neukum'" <oliver@...kum.org>, linux-kernel@...r.kernel.org
Subject: Re: question on tty open and close

Alan Cox wrote:
> I'm also not aware of any reason other than history, which means if
> someone cares to double check the other drivers there really shouldn't be
> an obstacle to "fixing" this behaviour.
> 
> Unless anyone knows different ?

As long as the new behavior continues to call
driver->close() if driver->open() succeeds
then I see no problem.

If individual drivers are correctly doing internal
reference counting to handle driver->close() calls
without a preceding successful driver->open() call
(usually just doing nothing), then they should
continue to operate correctly without the extra
and unnecessary driver->close().

-- 
Paul Fulghum
Microgate Systems, Ltd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/