linux-kernel - Re: [PATCH] USB Elan FTDI: check for driver registration status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070328114125.d4f2e650.zaitcev@redhat.com>
Date:	Wed, 28 Mar 2007 11:41:25 -0700
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	"Luiz Fernando N. Capitulino" <lcapitulino@...driva.com.br>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel-list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB Elan FTDI: check for driver registration status

On Wed, 28 Mar 2007 20:00:32 +0400, Cyrill Gorcunov <gorcunov@...il.com> wrote:

>          result = usb_register(&ftdi_elan_driver);
> -        if (result)
> +        if (result) {
> +		destroy_workqueue(status_queue);
> +		destroy_workqueue(command_queue);
> +		destroy_workqueue(respond_queue);
>                  printk(KERN_ERR "usb_register failed. Error number %d\n",
>  		       result);

I would just change the printk from "couldn't create workqueue"
to something more neutral, but this is ok too. Let's just declare
it fixed and move on.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/