linux-kernel - Re: [KJ][PATCH] BIT macro cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070328190925.GC5306@martell.zuzino.mipt.ru>
Date:	Wed, 28 Mar 2007 23:09:25 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Milind Arun Choudhary <milindchoudhary@...il.com>
Cc:	kernel-janitors@...ts.osdl.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [KJ][PATCH] BIT macro cleanup

On Wed, Mar 28, 2007 at 09:03:09AM +0530, Milind Arun Choudhary wrote:
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -8,6 +8,9 @@
>   */
>  #include <asm/bitops.h>
>
> +#define BIT(nr)	(1UL << ((nr) % BITS_PER_LONG))

I think this would be a disaster because something like

	BIT(123)

would not even generate a warning.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/