linux-kernel - Re: [PATCH 1/21] MSI: Simplify BUG() handling in pci_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <m1tzw6t5qc.fsf@ebiederm.dsl.xmission.com>
Date:	Tue, 27 Mar 2007 21:19:23 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	linux-pci@...ey.karlin.mff.cuni.cz,
	Greg Kroah-Hartman <greg@...ah.com>,
	"David S. Miller" <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	<linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	<daniel.e.wolstenholme@...el.com>
Subject: Re: [PATCH 1/21] MSI: Simplify BUG() handling in pci_disable_msi()

Michael Ellerman <michael@...erman.id.au> writes:

> Although it might be nice to do a printk before BUG'ing, it's really not
> necessary, and it complicates the code.
>

Acked-by: Eric W. Biederman <ebiederm@...ssion.com>

> Signed-off-by: Michael Ellerman <michael@...erman.id.au>
> ---
>
>  drivers/pci/msi.c |   19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
>
> Index: msi-new/drivers/pci/msi.c
> ===================================================================
> --- msi-new.orig/drivers/pci/msi.c
> +++ msi-new/drivers/pci/msi.c
> @@ -646,18 +646,15 @@ void pci_disable_msi(struct pci_dev* dev
>  	if (!entry || !entry->dev || entry->msi_attrib.type != PCI_CAP_ID_MSI) {
>  		return;
>  	}
> -	if (irq_has_action(dev->first_msi_irq)) {
> - printk(KERN_WARNING "PCI: %s: pci_disable_msi() called without "
> -		       "free_irq() on MSI irq %d\n",
> -		       pci_name(dev), dev->first_msi_irq);
> -		BUG_ON(irq_has_action(dev->first_msi_irq));
> -	} else {
> -		default_irq = entry->msi_attrib.default_irq;
> -		msi_free_irq(dev, dev->first_msi_irq);
>  
> -		/* Restore dev->irq to its default pin-assertion irq */
> -		dev->irq = default_irq;
> -	}
> +	BUG_ON(irq_has_action(dev->first_msi_irq));
> +
> +	default_irq = entry->msi_attrib.default_irq;
> +	msi_free_irq(dev, dev->first_msi_irq);
> +
> +	/* Restore dev->irq to its default pin-assertion irq */
> +	dev->irq = default_irq;
> +
>  	dev->first_msi_irq = 0;
>  }
>  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/