linux-kernel - Re: [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <460AD940.8080507@google.com>
Date:	Wed, 28 Mar 2007 14:08:16 -0700
From:	Ethan Solomita <solo@...gle.com>
To:	Andreas Mohr <andi@...x01.fht-esslingen.de>
CC:	Alexey Dobriyan <adobriyan@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Maneesh Soni <maneesh@...ibm.com>, Greg KH <greg@...ah.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)

Andreas Mohr wrote:
> Hi,
>
> On Wed, Mar 28, 2007 at 10:56:32PM +0400, Alexey Dobriyan wrote:
>   
>> The only suspicious new patch in -rc5-mm1 to me is
>> fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note
>> that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL.
>>
>> Could you try to revert it?
>>
>> 	Alexey, who knows very little about sysfs internals
>>     
>
> Apparently that's still too much knowledge ;)
>
> Or, in other words: 6 reboots already and not a single problem!
>
> So yes, the removal of the NULLing line in this patch most likely
> has caused this issue on my box.
> Now the question is whether something as simple as that is a fully
> correct fix or whether something should be done entirely differently.
> I'll let people more familiar with those parts decide about it...
>   

    Sorry -- I've only just been cc'd on this mail thread. Are we 
claiming that this patch/fix has caused a new problem, or successfully 
fixed an old problem?

    Thanks!
    -- Ethan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/