lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 27 Mar 2007 23:54:43 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	linux-pci@...ey.karlin.mff.cuni.cz,
	Greg Kroah-Hartman <greg@...ah.com>,
	"David S. Miller" <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	<linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	<daniel.e.wolstenholme@...el.com>
Subject: Re: [PATCH 10/21] MSI: Add an arch_msi_supported()

Michael Ellerman <michael@...erman.id.au> writes:

> Add an arch_msi_supported(), which gives archs a chance to check the input
> to pci_enable_msi/x. For MSI-X this routine might need the entry array, so
> pass it in. For plain MSI, NULL is passed, the arch routine needs to cope
> with that. Propagate the error value returned from the arch routine out to
> the caller.

Ugh.  I'm not very comfortable with passing struct msix_entry into
the architectures right now.

There are a couple of reasons.
- It's irq field is to small (so we need to change it at some point)
- No a single driver that calls pci_enable_msix uses the scatter gather
  feature (so the entry member is redundant).

So this struct msix_entry needs to change and we need to change the drivers
along with it.  Having to change a couple of architectures as well sounds
painful.  So we might as well fix that at the same time as we are
adding the RTAS support so architectures don't have to deal with this
nasty unused concept.

I'm thinking the same thing to do is to completely remove struct msix_entry
and just let drivers walk the linked list you introduce a few patches
later down.  All they need is to get their irq numbers anyway.

I was tempted to drop nvec as well since our irq numbers are virtual,
we could always delay the failure into request_irq.  But there are
a few embedded architectures like the arm where the number irqs
numbers may stay limited for a long time and if the driver will never
use all of the irqs we get to save some resources and some work.  So
that makes sense.

So can we please at least move this patch down to the end with the
rest of the RTAS arch support?

Moving it towards the end will allow it to be reviewed in the context
where it will be used and it will give us a chance to simplify
pci_enable_msix before we get there.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists